hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6163) FS Preemption is a trickle for severely starved applications
Date Wed, 15 Feb 2017 19:04:41 GMT

    [ https://issues.apache.org/jira/browse/YARN-6163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15868372#comment-15868372
] 

ASF GitHub Bot commented on YARN-6163:
--------------------------------------

Github user templedf commented on a diff in the pull request:

    https://github.com/apache/hadoop/pull/192#discussion_r101356264
  
    --- Diff: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/TestVisitedResourceRequestTracker.java
---
    @@ -0,0 +1,101 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at*
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair;
    +
    +import org.apache.hadoop.yarn.api.records.Priority;
    +import org.apache.hadoop.yarn.api.records.ResourceRequest;
    +import org.apache.hadoop.yarn.server.resourcemanager.MockNodes;
    +import org.apache.hadoop.yarn.server.resourcemanager.rmnode.RMNode;
    +import org.apache.hadoop.yarn.server.resourcemanager.scheduler.ClusterNodeTracker;
    +import org.apache.hadoop.yarn.util.resource.Resources;
    +import org.junit.Assert;
    +import org.junit.Test;
    +
    +import java.util.List;
    +
    +public class TestVisitedResourceRequestTracker {
    +  private final ClusterNodeTracker<FSSchedulerNode>
    +      nodeTracker = new ClusterNodeTracker<>();
    +  private final ResourceRequest
    +      anyRequest, rackRequest, node1Request, node2Request;
    +
    +  public TestVisitedResourceRequestTracker() {
    +    List<RMNode> rmNodes =
    +        MockNodes.newNodes(1, 2, Resources.createResource(8192, 8));
    +
    +    FSSchedulerNode node1 = new FSSchedulerNode(rmNodes.get(0), false);
    +    nodeTracker.addNode(node1);
    +    node1Request = createRR(node1.getNodeName(), 1);
    +
    +    FSSchedulerNode node2 = new FSSchedulerNode(rmNodes.get(1), false);
    +    node2Request = createRR(node2.getNodeName(), 1);
    +    nodeTracker.addNode(node2);
    +
    +    anyRequest = createRR(ResourceRequest.ANY, 2);
    +    rackRequest = createRR(node1.getRackName(), 2);
    +  }
    +
    +  private ResourceRequest createRR(String resourceName, int count) {
    +    return ResourceRequest.newInstance(
    +        Priority.UNDEFINED, resourceName, Resources.none(), count);
    +  }
    +
    +  @Test
    +  public void testVisitAnyRequestFirst() {
    +    VisitedResourceRequestTracker tracker =
    +        new VisitedResourceRequestTracker(nodeTracker);
    +
    +    // Visit ANY request first
    +    Assert.assertTrue(tracker.visit(anyRequest));
    --- End diff --
    
    The reason I want messages is if we're looking to see if a failure is a known failure,
getting a failed assertFalse (null) on line 67 versus a failed assertFalse (null) on line
68 isn't very illuminating.


> FS Preemption is a trickle for severely starved applications
> ------------------------------------------------------------
>
>                 Key: YARN-6163
>                 URL: https://issues.apache.org/jira/browse/YARN-6163
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: fairscheduler
>    Affects Versions: 2.9.0
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>         Attachments: YARN-6163.004.patch, YARN-6163.005.patch, yarn-6163-1.patch, yarn-6163-2.patch
>
>
> With current logic, only one RR is considered per each instance of marking an application
starved. This marking happens only on the update call that runs every 500ms.  Due to this,
an application that is severely starved takes forever to reach fairshare based on preemptions.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message