hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6163) FS Preemption is a trickle for severely starved applications
Date Wed, 15 Feb 2017 04:00:44 GMT

    [ https://issues.apache.org/jira/browse/YARN-6163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867177#comment-15867177
] 

ASF GitHub Bot commented on YARN-6163:
--------------------------------------

Github user kambatla commented on a diff in the pull request:

    https://github.com/apache/hadoop/pull/192#discussion_r101199875
  
    --- Diff: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSAppAttempt.java
---
    @@ -1147,24 +1147,32 @@ private static boolean checkAndMarkRRVisited(
        * starvation.
        */
       List<ResourceRequest> getStarvedResourceRequests() {
    +    // List of RRs we build in this method to return
         List<ResourceRequest> ret = new ArrayList<>();
    +
    +    // Track visited RRs to avoid the same RR at multiple locality levels
         Map<Priority, List<Resource>> visitedRRs= new HashMap<>();
     
    +    // Start with current starvation and track the pending amount
         Resource pending = getStarvation();
         for (ResourceRequest rr : appSchedulingInfo.getAllResourceRequests()) {
           if (Resources.isNone(pending)) {
    +        // Found enough RRs to match the starvation
             break;
           }
    +
    +      // See if we have already seen this RR
           if (checkAndMarkRRVisited(visitedRRs, rr)) {
             continue;
           }
     
    -      // Compute the number of containers of this capability that fit in the
    -      // pending amount
    +      // A RR can have multiple containers of a capability. We need to
    +      // compute the number of containers that fit in "pending".
           int ratio = (int) Math.floor(
    --- End diff --
    
    Fixed.


> FS Preemption is a trickle for severely starved applications
> ------------------------------------------------------------
>
>                 Key: YARN-6163
>                 URL: https://issues.apache.org/jira/browse/YARN-6163
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: fairscheduler
>    Affects Versions: 2.9.0
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>         Attachments: yarn-6163-1.patch, yarn-6163-2.patch
>
>
> With current logic, only one RR is considered per each instance of marking an application
starved. This marking happens only on the update call that runs every 500ms.  Due to this,
an application that is severely starved takes forever to reach fairshare based on preemptions.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message