hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sunil G (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6156) AM blacklisting consider node label partition
Date Tue, 14 Feb 2017 06:37:41 GMT

    [ https://issues.apache.org/jira/browse/YARN-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15865176#comment-15865176
] 

Sunil G commented on YARN-6156:
-------------------------------

[~bibinchundatt], Quickly skimmed through the patch.

Few more comments:
1. {{getApplicableNodeCountForAM}} could be moved to {{RMServerUtils}} to avoid duplicate
code.
2. In {{getApplicableNodeCountForAM}}, {{amNodeLabelExpression}} could be moved inside if
block as its local.
3. Add javadoc for {{getNodeCountByLabel}}
4. {{getNodeCountByLabel}} -> {{getActiveNMsCountPerLabel}}. Its a suggestion, pls feel
free to make it better.
5. In {{testBlacklistAMDisableLabel}}, could you also close or stop {{rm}}
6. Comment is not correct. {{// Nodes in label x h4,h5,h7}} It should be for label *y*


> AM blacklisting  consider node label partition
> ----------------------------------------------
>
>                 Key: YARN-6156
>                 URL: https://issues.apache.org/jira/browse/YARN-6156
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>         Attachments: YARN-6156.0001.patch, YARN-6156.0002.patch, YARN-6156.0003.patch
>
>
> As per the current implementation for AM blacklisting disabling is based on completed
custer resource.
> Incase of partitioned cluster, nodes applicable for AM labels only should be considered
as total nodes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message