hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jian He (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6153) keepContainer does not work when AM retry window is set
Date Mon, 13 Feb 2017 23:33:41 GMT

    [ https://issues.apache.org/jira/browse/YARN-6153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864677#comment-15864677
] 

Jian He commented on YARN-6153:
-------------------------------

[~kyungwan nam], thanks for the patch.  Minor suggestion to the code:
In RMAppImpl, we also have below code to detect whether a failure should be counted towards
the max-retry. I think we can move the logic of checking the validity interval inside shouldCountTowardsMaxAttemptRetry
itself, so that this method could be used by both RMAppImpl and RMAttemptImpl 
{code}
      if (attempt.shouldCountTowardsMaxAttemptRetry()) {
        if (this.attemptFailuresValidityInterval <= 0
            || (attempt.getFinishTime() > endTime
                - this.attemptFailuresValidityInterval)) {
          completedAttempts++;
        }
      }
{code}

> keepContainer does not work when AM retry window is set
> -------------------------------------------------------
>
>                 Key: YARN-6153
>                 URL: https://issues.apache.org/jira/browse/YARN-6153
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 2.7.1
>            Reporter: kyungwan nam
>         Attachments: YARN-6153.001.patch
>
>
> yarn.resourcemanager.am.max-attempts has been configured to 2 in my cluster.
> I submitted a YARN application (slider app) that keepContainers=true, attemptFailuresValidityInterval=300000.
> it did work properly when AM was failed firstly.
> all containers launched by previous AM were resynced with new AM (attempt2) without killing
containers.
> after 10 minutes, I thought AM failure count was reset by attemptFailuresValidityInterval
(5 minutes).
> but, all containers were killed when AM was failed secondly. (new AM attempt3 was launched
properly)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message