hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6143) Fix incompatible issue caused by YARN-3583
Date Mon, 13 Feb 2017 21:29:42 GMT

    [ https://issues.apache.org/jira/browse/YARN-6143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864480#comment-15864480
] 

Wangda Tan commented on YARN-6143:
----------------------------------

Thanks [~sunilg], a couple of comments:

1) For AddToClusterNodeLabelsRequestProto:

1.1 change it to:
{code}
message AddToClusterNodeLabelsRequestProto {
  repeated string deprecatedNodeLabels = 1;
  repeated NodeLabelProto nodeLabels = 2;
}
{code}

Since rename a field is a compatible change.

1.2 Not need to change/add any API of AddToClusterNodeLabelRequest, since they're all *unstable
Java API*, we don't need to keep compatibility here.

1.3 We can revert most of the logics in AddToClusterNodeLabelRequestPBImpl, the only thing
need to change is {{initLocalNodeLabels}}, it will try to look at if {{nodeLabels}} is not
null, if it is not null, it will not try to read from {{deprecatedNodeLabels}}. 

2) Similar changes can be made to GetClusterNodeLabelsResponse:

2.1 change proto file to:
{code}
message GetClusterNodeLabelsResponseProto {
  repeated string deprecatedNodeLabels = 1;
  repeated NodeLabelProto nodeLabels = 2;
}
{code}

2.2 Keep deprecated fields in GetClusterNodeLabelsResponse.java
2.3 The only change of GetClusterNodeLabelsResponsePBImpl is: addNodeLabelsToProto should
set both field: deprecatedNodeLabels and nodeLabels. Since we expect older client talk to
newer server. (But not vice-versa).

> Fix incompatible issue caused by YARN-3583
> ------------------------------------------
>
>                 Key: YARN-6143
>                 URL: https://issues.apache.org/jira/browse/YARN-6143
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: rolling upgrade
>            Reporter: Wangda Tan
>            Assignee: Sunil G
>            Priority: Blocker
>         Attachments: YARN-6143.0001.patch
>
>
> As mentioned by comment: https://issues.apache.org/jira/browse/YARN-6142?focusedCommentId=15852009&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15852009.
We need to fix the incompatible issue caused by YARN-3583.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message