hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6143) Fix incompatible issue caused by YARN-3583
Date Sat, 04 Feb 2017 20:17:51 GMT

    [ https://issues.apache.org/jira/browse/YARN-6143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15852923#comment-15852923
] 

Wangda Tan commented on YARN-6143:
----------------------------------

This is what I found need to be changed:

1) yarn_protos.proto
- NodeIdToLabelsInfoProto -> NodeIdToLabelsProto, and change nodeLabels's type to string
- LabelsToNodeIdsProto, change nodeLabels's type to string 

2) yarn_server_resourcemanager_service_protos.proto:
- AddToClusterNodeLabelsRequestProto, keep original {{string nodeLabels = 1}} and add {{repeated
NodeLabelProto nodeLabelsWithExclusivity = 2}}. (Additional changes required to PB and service)
- ReplaceLabelsOnNodeRequestProto, NodeIdToLabelsNameProto -> NodeIdToLabelsProto

3) yarn_service_proto.proto
- GetNodesToLabelsResponseProto, change type of nodeToLabels to NodeIdTolabelsProto. (Additional
changes required to Java APIs, returned map should be String instead of NodeLabel)
- GetClusterNodeLabelsResponseProto, keep original {{string nodeLabels = 1}} and add {{repeated
NodeLabelProto nodeLabelsWithExclusivity = 2}}. (Additional changes required to PB and service)

Hopefully it captured everything, [~sunilg], could you help to take a look. 

I used script shared by [~mackrorysd] at comment: https://issues.apache.org/jira/browse/HDFS-11096?focusedCommentId=15816405&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15816405,
thanks Sean for sharing it! ("meld" need to run {{brew install Caskroom/cask/meld}} to install.)

> Fix incompatible issue caused by YARN-3583
> ------------------------------------------
>
>                 Key: YARN-6143
>                 URL: https://issues.apache.org/jira/browse/YARN-6143
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: rolling upgrade
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>            Priority: Blocker
>
> As mentioned by comment: https://issues.apache.org/jira/browse/YARN-6142?focusedCommentId=15852009&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15852009.
We need to fix the incompatible issue caused by YARN-3583.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message