hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6061) Add a customized uncaughtexceptionhandler for critical threads in RM
Date Tue, 07 Feb 2017 22:45:42 GMT

    [ https://issues.apache.org/jira/browse/YARN-6061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856953#comment-15856953
] 

ASF GitHub Bot commented on YARN-6061:
--------------------------------------

Github user kambatla commented on a diff in the pull request:

    https://github.com/apache/hadoop/pull/182#discussion_r99948742
  
    --- Diff: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMCriticalThreadUncaughtExceptionHandler.java
---
    @@ -0,0 +1,60 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.hadoop.yarn.server.resourcemanager;
    +
    +import java.lang.Thread.UncaughtExceptionHandler;
    +
    +import org.apache.commons.logging.Log;
    +import org.apache.commons.logging.LogFactory;
    +import org.apache.hadoop.classification.InterfaceAudience.Public;
    +import org.apache.hadoop.classification.InterfaceStability.Evolving;
    +import org.apache.hadoop.yarn.conf.HAUtil;
    +
    +/**
    + * This class either shutdowns {@link ResourceManager} or makes
    --- End diff --
    
    - s/shutdowns/shuts down
    - s/makes RM transition/ transitions the RM
    - s/if any uncaught exception.../if a critical thread throws an uncaught exception. 


> Add a customized uncaughtexceptionhandler for critical threads in RM
> --------------------------------------------------------------------
>
>                 Key: YARN-6061
>                 URL: https://issues.apache.org/jira/browse/YARN-6061
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: resourcemanager
>            Reporter: Yufei Gu
>            Assignee: Yufei Gu
>         Attachments: YARN-6061.001.patch, YARN-6061.002.patch, YARN-6061.003.patch, YARN-6061.004.patch,
YARN-6061.005.patch, YARN-6061.006.patch, YARN-6061.007.patch
>
>
> There are several threads in fair scheduler. The thread will quit when there is a runtime
exception inside it. We should bring down the RM when that happens. Otherwise, there may be
some weird behavior in RM. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message