[ https://issues.apache.org/jira/browse/YARN-6059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862607#comment-15862607
]
Hitesh Sharma commented on YARN-6059:
-------------------------------------
Hi [~kkaranasos], thanks for the feedback! [~asuresh], can you also take a look, please?
bq. The paused events are not stored in the NMStateStore. You need to add that in the ContainerScheduler,
as we do for the QUEUED containers, e.g., with this.context.getNMStateStore().storeContainerQueued.
Thanks, fixed this.
bq. You need to make sure that, when a PAUSED container is relaunched, we add a new entry
to the NMStateStore to mark it as RUNNING again.
We don't launch the paused container and instead we simply kill it.
bq. In the RecoverPausedContainerLaunch, you should raise a ContainerEvent to indicate that
the container finished its execution, like we do with the other *ContainerLaunch classes,
with something like the following:
Hmm..since we kill the container an event for that will be raised automatically. Am I missing
something?
bq. In RecoveredContainerLaunch, indentation needs to be fixed.
Can you elaborate? I don't see any stylecheck errors for this.
> Update paused container state in the state store
> ------------------------------------------------
>
> Key: YARN-6059
> URL: https://issues.apache.org/jira/browse/YARN-6059
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Hitesh Sharma
> Assignee: Hitesh Sharma
> Attachments: YARN-5216-YARN-6059.001.patch, YARN-6059-YARN-5972.001.patch, YARN-6059-YARN-5972.002.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org
|