hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Varun Saxena (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6027) Support fromid(offset) filter for /flows API
Date Fri, 17 Feb 2017 20:19:41 GMT

    [ https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872457#comment-15872457

Varun Saxena commented on YARN-6027:

By the way can we refactor the Timeline UID converter class to accomodate encoding/decoding
of fromId as per the offline discussion we had?
However, if we keep it at a storage layer, we can also have a separate class(but modeled along
the lines of uid converter class) so that we do not mix up potentially unrelated areas.
I think that is one major comment on the patch. Let me know your thoughts on it. We can have
a detailed review based on that.

In the current patch, we are splitting fromId in web services and also passing it to storage
layer, which seems a little weird.
Also I noticed that the message while throwing BadRequestException is "Invalid fromid has
provided". We can say "Invalid fromid has been provided" or "Invalid fromid in request"

> Support fromid(offset) filter for /flows API
> --------------------------------------------
>                 Key: YARN-6027
>                 URL: https://issues.apache.org/jira/browse/YARN-6027
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>              Labels: yarn-5355-merge-blocker
>         Attachments: YARN-6027-YARN-5355.0001.patch, YARN-6027-YARN-5355.0002.patch,
> In YARN-5585 , fromId is supported for retrieving entities. We need similar filter for
flows/flowRun apps and flow run and flow as well. 
> Along with supporting fromId, this JIRA should also discuss following points
> * Should we throw an exception for entities/entity retrieval if duplicates found?
> * TimelieEntity :
> ** Should equals method also check for idPrefix?
> ** Does idPrefix is part of identifiers?

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org

View raw message