hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Varun Saxena (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (YARN-6027) Support fromid(offset) filter for /flows API
Date Fri, 17 Feb 2017 09:54:42 GMT

    [ https://issues.apache.org/jira/browse/YARN-6027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871560#comment-15871560
] 

Varun Saxena edited comment on YARN-6027 at 2/17/17 9:53 AM:
-------------------------------------------------------------

[~rohithsharma], we had discussed this in yesterday's call. I think intention was to fit this
code into TimelineUIDConverter, not necessarily to return Flow UID per say (we can always
add another enum). This is because functionality for encoding and decoding of escape characters
and separators is in built in that class. 
So nobody was against adding a new field FROM_ID if FLOW_UID cannot serve our use case.

We can probably modify TimelineUIDConverter to suit our use case if we want as it is an internal
class. Maybe name it TimelineIDConverter or something else and add another enum for FROM_ID.
We can possibly pass an ID context which passes more things than just the TimelineReaderContext.
We can also use a builder pattern for it to help easy addition of fields. 

Havent thought it through but these are few possible options. 
Or you may have other suggestions.


was (Author: varun_saxena):
[~rohithsharma], we had discussed this in yesterday's call. I think intention was to fit this
code into TimelineUIDConverter, not necessarily to return Flow UID per say (we can always
add another enum). This is because functionality for encoding and decoding of escape characters
and separators is in built in that class. 
So nobody was against adding a new field FROM_ID if FLOW_UID cannot serve our use case.

We can probably modify TimelineUIDConverter to suit our use case if we want as it is an internal
class. Maybe name it TimelineIDConverter or something else.
We can possibly pass an ID context which passes more things than just the TimelineReaderContext.
We can also use a builder pattern for it to help easy addition of fields. 

Havent thought it through but these are few possible options. 
Or you may have other suggestions.

> Support fromid(offset) filter for /flows API
> --------------------------------------------
>
>                 Key: YARN-6027
>                 URL: https://issues.apache.org/jira/browse/YARN-6027
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>              Labels: yarn-5355-merge-blocker
>         Attachments: YARN-6027-YARN-5355.0001.patch, YARN-6027-YARN-5355.0002.patch
>
>
> In YARN-5585 , fromId is supported for retrieving entities. We need similar filter for
flows/flowRun apps and flow run and flow as well. 
> Along with supporting fromId, this JIRA should also discuss following points
> * Should we throw an exception for entities/entity retrieval if duplicates found?
> * TimelieEntity :
> ** Should equals method also check for idPrefix?
> ** Does idPrefix is part of identifiers?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message