hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Naganarasimha G R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5703) ReservationAgents are not correctly configured
Date Mon, 13 Feb 2017 18:06:41 GMT

    [ https://issues.apache.org/jira/browse/YARN-5703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864114#comment-15864114
] 

Naganarasimha G R commented on YARN-5703:
-----------------------------------------

Thanks for reworking on the whole patch [~manirajv06@gmail.com].
Few nits :
# ReservationSchedulerConfiguration, ln no 61, 64, 67, 70 : IMO lets keep it similar to earlier
approach or at the max move it to {{YarnConfiguration}}. For issue described in jira we do
not require this movement. Also we need to revert modifications in other class too.
# PlanningAlgorithm, ln no 212, remove ??//do nothing??
# TryManyReservationAgents, ln no 117, remove ??//do nothing??
# checkstyle, white space and javadoc seems to be related to the patch

Test case failures not related to this jira.

 

> ReservationAgents are not correctly configured
> ----------------------------------------------
>
>                 Key: YARN-5703
>                 URL: https://issues.apache.org/jira/browse/YARN-5703
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: capacity scheduler, resourcemanager
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Sean Po
>            Assignee: Manikandan R
>         Attachments: YARN-5703.001.patch, YARN-5703.002.patch, YARN-5703.003.patch, YARN-5703.004.patch,
YARN-5703.005.patch
>
>
> In AbstractReservationSystem, the method that instantiates a ReservationAgent does not
properly initialize it with the appropriate configuration because it expects the ReservationAgent
to implement Configurable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message