hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Naganarasimha G R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5703) ReservationAgents are not correctly configured
Date Thu, 02 Feb 2017 20:34:51 GMT

    [ https://issues.apache.org/jira/browse/YARN-5703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15850445#comment-15850445
] 

Naganarasimha G R commented on YARN-5703:
-----------------------------------------

thanks [~manirajv06@gmail.com] for working on the patch, please find my comments : 
* AbstractReservationSystem,  ln no 452: I think we can better use {{agentclass = Configuration.getClass(String,
Class<? extends U>, Class<U>)}} and then call {{agentClass.newInstance()}} here
instead of current approach and better to avoid {{ReflectionUtils.newInstance(Class<T>,
Configuration)}} which seems to cache constructors if not present. This seems to be used mainly
by MR earlier.

* ReservationAgent, ln no 80 : {{init(ReservationSchedulerConfiguration conf)}} it should
be only {{Configuration}} and not *ReservationSchedulerConfiguration* as it is its subclass.

* AlignedPlannerWithGreedy, ln no 38 : need not extend Configurable, and also add a method
for {{ReservationAgent.init}} method. I would suggest to only have {{ReservationAgent.init}}.
Also configurable does not any way seem to suit here.

* AlignedPlannerWithGreedy, ln no 38 : {{yarnConf}} would not require local vairable if plan
as above
IterativePlanner.java, ln no 429: why do we require {{init(ReservationSchedulerConfiguration
conf)}}?

> ReservationAgents are not correctly configured
> ----------------------------------------------
>
>                 Key: YARN-5703
>                 URL: https://issues.apache.org/jira/browse/YARN-5703
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: capacity scheduler, resourcemanager
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Sean Po
>            Assignee: Manikandan R
>         Attachments: YARN-5703.001.patch, YARN-5703.002.patch
>
>
> In AbstractReservationSystem, the method that instantiates a ReservationAgent does not
properly initialize it with the appropriate configuration because it expects the ReservationAgent
to implement Configurable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message