hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sangjin Lee (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4675) Reorganize TimelineClient and TimelineClientImpl into separate classes for ATSv1.x and ATSv2
Date Mon, 13 Feb 2017 20:53:41 GMT

    [ https://issues.apache.org/jira/browse/YARN-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864400#comment-15864400

Sangjin Lee commented on YARN-4675:

Thanks for the updated patch [~Naganarasimha]!

If it is not too much, could you kindly prepare the YARN-5355 patch in addition to the trunk
patch so that we can commit this to both trunk and YARN-5355? This is a fairly major API change
and we'd like to have that in YARN-5355 as early as possible.

A couple more (all minor) comments:
- AMRMClient.registerTimelineV2Client(): should we throw an exception if this method is called
and timeline service v.2 is not enabled? The case would likely be a code bug, and we probably
need a stronger failure to catch this
- There still seem to be a few checkstyle issues that are related with the patch and they
seem fixable. Could you please look into them?

Thanks Naga!

> Reorganize TimelineClient and TimelineClientImpl into separate classes for ATSv1.x and
> --------------------------------------------------------------------------------------------
>                 Key: YARN-4675
>                 URL: https://issues.apache.org/jira/browse/YARN-4675
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>              Labels: YARN-5355, yarn-5355-merge-blocker
>         Attachments: YARN-4675.v2.002.patch, YARN-4675.v2.003.patch, YARN-4675.v2.004.patch,
YARN-4675.v2.005.patch, YARN-4675.v2.006.patch, YARN-4675.v2.007.patch, YARN-4675.v2.008.patch,
> We need to reorganize TimeClientImpl into TimeClientV1Impl ,  TimeClientV2Impl and if
required a base class, so that its clear which part of the code belongs to which version and
thus better maintainable.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org

View raw message