hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Varun Saxena (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4675) Reorganize TimeClientImpl into TimeClientV1Impl and TimeClientV2Impl
Date Wed, 08 Feb 2017 13:44:41 GMT

    [ https://issues.apache.org/jira/browse/YARN-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858001#comment-15858001
] 

Varun Saxena commented on YARN-4675:
------------------------------------

Thanks [~Naganarasimha] for the patch. Looks pretty close. Few minor comments

# In TimelineConnector, connectionRetry should be annotated with VisibleForTesting
# Can't we add a serviceInit method in AMRMClient which stores the value of timeline service
v2 enabled instead of adding an abstract method registerTimelineV2Client.
# The changes here need to be reflected in timeline v2 documentation as well. You want to
do it here or another JIRA? As the change is very small, maybe we can do it here itself. Thoughts?
# In YarnClientImpl, we check for YarnConfiguration#timelineServiceV2Enabled and this will
check for timeline service enabled again. We can use YarnConfiguration#getTimelineServiceVersion
instead. This can be done at other places as well.
{code}
170	    if (conf.getBoolean(YarnConfiguration.TIMELINE_SERVICE_ENABLED,
171	        YarnConfiguration.DEFAULT_TIMELINE_SERVICE_ENABLED)
172	        && !YarnConfiguration.timelineServiceV2Enabled(conf)) {
{code}

By the way can other checkstyle issues be fixed? Few exist from before though and are appearing
in report just because you renamed the variable.


> Reorganize TimeClientImpl into TimeClientV1Impl and TimeClientV2Impl
> --------------------------------------------------------------------
>
>                 Key: YARN-4675
>                 URL: https://issues.apache.org/jira/browse/YARN-4675
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>              Labels: YARN-5355, yarn-5355-merge-blocker
>         Attachments: YARN-4675.v2.002.patch, YARN-4675.v2.003.patch, YARN-4675.v2.004.patch,
YARN-4675.v2.005.patch, YARN-4675.v2.006.patch, YARN-4675.v2.007.patch, YARN-4675-YARN-2928.v1.001.patch
>
>
> We need to reorganize TimeClientImpl into TimeClientV1Impl ,  TimeClientV2Impl and if
required a base class, so that its clear which part of the code belongs to which version and
thus better maintainable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message