hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4212) FairScheduler: Parent queues is not allowed to be 'Fair' policy if its children have the "drf" policy
Date Tue, 07 Feb 2017 23:17:42 GMT

    [ https://issues.apache.org/jira/browse/YARN-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857003#comment-15857003
] 

ASF GitHub Bot commented on YARN-4212:
--------------------------------------

Github user kambatla commented on a diff in the pull request:

    https://github.com/apache/hadoop/pull/181#discussion_r99954456
  
    --- Diff: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSQueue.java
---
    @@ -91,20 +91,22 @@ public FSQueue(String name, FairScheduler scheduler, FSParentQueue
parent) {
         this.queueEntity = new PrivilegedEntity(EntityType.QUEUE, name);
         this.metrics = FSQueueMetrics.forQueue(getName(), parent, true, scheduler.getConf());
         this.parent = parent;
    +    setPolicy(scheduler.getAllocationConfiguration().getSchedulingPolicy(name));
         reinit(false);
       }
     
       /**
        * Initialize a queue by setting its queue-specific properties and its
    -   * metrics.
    +   * metrics. This function don't set the policy for queues since there is
    --- End diff --
    
    s/function/method - there is one other instance of this in the javadoc
    
    s/don't/does not
    
    Instead of saying there is different logic, can we call out what method does that for
easier code navigability? And, it might be worth mentioning why that logic is separated, either
here or at the other method.


> FairScheduler: Parent queues is not allowed to be 'Fair' policy if its children have
the "drf" policy
> -----------------------------------------------------------------------------------------------------
>
>                 Key: YARN-4212
>                 URL: https://issues.apache.org/jira/browse/YARN-4212
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Arun Suresh
>            Assignee: Yufei Gu
>              Labels: fairscheduler
>         Attachments: YARN-4212.002.patch, YARN-4212.003.patch, YARN-4212.004.patch, YARN-4212.005.patch,
YARN-4212.006.patch, YARN-4212.007.patch, YARN-4212.008.patch, YARN-4212.1.patch
>
>
> The Fair Scheduler, while performing a {{recomputeShares()}} during an {{update()}} call,
uses the parent queues policy to distribute shares to its children.
> If the parent queues policy is 'fair', it only computes weight for memory and sets the
vcores fair share of its children to 0.
> Assuming a situation where we have 1 parent queue with policy 'fair' and multiple leaf
queues with policy 'drf', Any app submitted to the child queues with vcore requirement >
1 will always be above fairshare, since during the recomputeShare process, the child queues
were all assigned 0 for fairshare vcores.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message