hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Haibo Chen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-1728) History server doesn't understand percent encoded paths
Date Wed, 22 Feb 2017 21:57:44 GMT

    [ https://issues.apache.org/jira/browse/YARN-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879322#comment-15879322
] 

Haibo Chen commented on YARN-1728:
----------------------------------

Thanks [~yuanbo] for the patch! The patch looks good to me except for two knits
1) bq. // Make sure path is decoded.
This is confusing if we just look at javadoc in HttpServletRequest.getPathInfo() based on
the method signature, because it already decodes the URL. Maybe we should explicitly mention
Guice 3.0 here to make it clear
2) The unit test is added to an existing test method for custom routes. I think we should
create a new test method specifically for the decoding issue here.

> History server doesn't understand percent encoded paths
> -------------------------------------------------------
>
>                 Key: YARN-1728
>                 URL: https://issues.apache.org/jira/browse/YARN-1728
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Abraham Elmahrek
>            Assignee: Yuanbo Liu
>         Attachments: YARN-1728-branch-2.001.patch
>
>
> For example, going to the job history server page http://localhost:19888/jobhistory/logs/localhost%3A8041/container_1391466602060_0011_01_000001/job_1391466602060_0011/admin/stderr
results in the following error:
> {code}
> Cannot get container logs. Invalid nodeId: test-cdh5-hue.ent.cloudera.com%3A8041
> {code}
> Where the url decoded version works:
> http://localhost:19888/jobhistory/logs/localhost:8041/container_1391466602060_0011_01_000001/job_1391466602060_0011/admin/stderr
> It seems like both should be supported as the former is simply percent encoding.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message