Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 10 Jan 2017 05:57:58 +0000 (UTC)
From: "Daniel Templeton (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.13032927.1483923582000.693139.1484027878395@Atlassian.JIRA>
In-Reply-To: <JIRA.13032927.1483923582000@Atlassian.JIRA>
References: <JIRA.13032927.1483923582000@Atlassian.JIRA> <JIRA.13032927.1483923582635@arcas>
Subject: [jira] [Commented] (YARN-6073) Misuse of format specifier in
 Preconditions.checkArgument
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 10 Jan 2017 05:58:00 -0000


    [ https://issues.apache.org/jira/browse/YARN-6073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15814006#comment-15814006 ] 

Daniel Templeton commented on YARN-6073:
----------------------------------------

Patch looks good to me.  +1

> Misuse of format specifier in Preconditions.checkArgument
> ---------------------------------------------------------
>
>                 Key: YARN-6073
>                 URL: https://issues.apache.org/jira/browse/YARN-6073
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Yongjun Zhang
>            Assignee: Yuanbo Liu
>            Priority: Trivial
>         Attachments: YARN-6073.001.patch
>
>
> RMAdminCLI.java
> {code}
>  int nLabels = map.get(nodeId).size();
>       Preconditions.checkArgument(nLabels <= 1, "%d labels specified on host=%s"
>           + ", please note that we do not support specifying multiple"
>           + " labels on a single host for now.", nLabels, nodeIdStr);
> {code}
> The {{%d}} should be replaced with {{%s}}, per
> https://google.github.io/guava/releases/19.0/api/docs/com/google/common/base/Preconditions.html


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org