hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Templeton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6022) Revert changes of AbstractResourceRequest
Date Wed, 04 Jan 2017 00:45:58 GMT

    [ https://issues.apache.org/jira/browse/YARN-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796729#comment-15796729
] 

Daniel Templeton commented on YARN-6022:
----------------------------------------

Looks generally good.  Thanks, [~leftnoteasy].  My only comment is that {{AbstractYarnScheduler.getNormalizeResource()}}
should be {{AbstractYarnScheduler.getNormalizedResource()}}.

> Revert changes of AbstractResourceRequest
> -----------------------------------------
>
>                 Key: YARN-6022
>                 URL: https://issues.apache.org/jira/browse/YARN-6022
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>            Priority: Blocker
>         Attachments: YARN-6022.001.patch, YARN-6022.002.patch
>
>
> YARN-5774 added AbstractResourceRequest to make easier internal scheduler change, this
is not a correct approach: For example, with this change, we need to make AbstractResourceRequest
to be public/stable. And end users can use it like:
> {code}
> AbstractResourceRequest request = ...
> request.setCapability(...)
> {code}
> But AbstractResourceRequest should not be visible by application at all. 
> We need to revert it from branch-2.8 / branch-2 / trunk. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message