hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-6000) Make AllocationFileLoaderService.Listener public
Date Mon, 09 Jan 2017 22:04:58 GMT

    [ https://issues.apache.org/jira/browse/YARN-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15812994#comment-15812994
] 

Sergey Shelukhin commented on YARN-6000:
----------------------------------------

Thanks! As for Hive requirements, see the code snippet above. We are using the listener because
that seems to be the only way to get the updated value out. We just need to get the allocConf/queue

> Make AllocationFileLoaderService.Listener public
> ------------------------------------------------
>
>                 Key: YARN-6000
>                 URL: https://issues.apache.org/jira/browse/YARN-6000
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: fairscheduler, yarn
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Tao Jie
>            Assignee: Tao Jie
>             Fix For: 3.0.0-alpha2
>
>         Attachments: YARN-6000.001.patch
>
>
> We removed public modifier of {{AllocationFileLoaderService.Listener}} in YARN-4997 since
it trigger a findbugs warning. However it breaks Hive code in {{FairSchedulerShim}}. 
> {code}
> AllocationFileLoaderService allocsLoader = new AllocationFileLoaderService();
>     allocsLoader.init(conf);
>     allocsLoader.setReloadListener(new AllocationFileLoaderService.Listener() {
>       @Override
>       public void onReload(AllocationConfiguration allocs) {
>         allocConf.set(allocs);
>       }
>     });
>     try {
>       allocsLoader.reloadAllocations();
>     } catch (Exception ex) {
>       throw new IOException("Failed to load queue allocations", ex);
>     }
>     if (allocConf.get() == null) {
>       allocConf.set(new AllocationConfiguration(conf));
>     }
>     QueuePlacementPolicy queuePolicy = allocConf.get().getPlacementPolicy();
>     if (queuePolicy != null) {
>       requestedQueue = queuePolicy.assignAppToQueue(requestedQueue, userName);
> {code}
> As a result we should set the modifier back to public.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message