hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5556) Support for deleting queues without requiring a RM restart
Date Tue, 10 Jan 2017 18:41:58 GMT

    [ https://issues.apache.org/jira/browse/YARN-5556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15815803#comment-15815803
] 

Wangda Tan commented on YARN-5556:
----------------------------------

Thanks [~Naganarasimha],

Generally looks good, few minor suggestions:

1) CSQueueManager:
- Better to update warn to info:
{code}
LOG.warn("Deleting Queue " + queueName + ", as it is not"
                + " present in the modified capacity configuration xml");
{code}
Since delete queue is a normal behavior
- "seems to be deleted" -> "is deleted from the new configuration"
- In {{updateQueues}}, oldQueues -> existingQueues

2) ParentQueue:
- In the "// remove the deleted queue in the refreshed xml", oldQueueName -> queueName

And for your comment above: 
bq. Better to append the exception message ...
Agree

bq. documentation needs to be updated, can either raise a new jira or add as part of this
jira for the steps to be delete the Queue in CS 
It's better to have a separate JIRA to add document.


> Support for deleting queues without requiring a RM restart
> ----------------------------------------------------------
>
>                 Key: YARN-5556
>                 URL: https://issues.apache.org/jira/browse/YARN-5556
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: yarn
>            Reporter: Xuan Gong
>            Assignee: Naganarasimha G R
>         Attachments: YARN-5556.v1.001.patch, YARN-5556.v1.002.patch, YARN-5556.v1.003.patch,
YARN-5556.v1.004.patch, YARN-5556.v2.005.patch
>
>
> Today, we could add or modify queues without restarting the RM, via a CS refresh. But
for deleting queue, we have to restart the ResourceManager. We could support for deleting
queues without requiring a RM restart



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message