hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ajith S (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5547) NMLeveldbStateStore should be more tolerant of unknown keys
Date Thu, 05 Jan 2017 09:51:58 GMT

    [ https://issues.apache.org/jira/browse/YARN-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15800932#comment-15800932
] 

Ajith S commented on YARN-5547:
-------------------------------

Hi guys, sorry for delay. [~jlowe]  thanks for your comments. You are right, we can avoid
storing killed state for container which will not be recovered. Also, for deleting the unknown
keys,  would it be ok to remove unknown keys in {{NMLeveldbStateStoreService.loadContainerState(ContainerId,
LeveldbIterator, String)}} .? As per the patch it will be after the warning log about the
unknown keys
This will avoid any scanning of store hence forth avoid performance penalty

> NMLeveldbStateStore should be more tolerant of unknown keys
> -----------------------------------------------------------
>
>                 Key: YARN-5547
>                 URL: https://issues.apache.org/jira/browse/YARN-5547
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: nodemanager
>    Affects Versions: 2.6.0
>            Reporter: Jason Lowe
>            Assignee: Ajith S
>         Attachments: YARN-5547.01.patch, YARN-5547.02.patch, YARN-5547.03.patch
>
>
> Whenever new keys are added to the NM state store it will break rolling downgrades because
the code will throw if it encounters an unrecognized key.  If instead it skipped unrecognized
keys it could be simpler to continue supporting rolling downgrades.  We need to define the
semantics of unrecognized keys when containers and apps are cleaned up, e.g.: we may want
to delete all keys underneath an app or container directory when it is being removed from
the state store to prevent leaking unrecognized keys.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message