hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5219) When an export var command fails in launch_container.sh, the full container launch should fail
Date Sun, 08 Jan 2017 16:35:58 GMT

    [ https://issues.apache.org/jira/browse/YARN-5219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15809650#comment-15809650
] 

Allen Wittenauer commented on YARN-5219:
----------------------------------------

bq. After the export section in launch_container.sh, i think its fine to add back "set +e".

Why?  If the container launch script has failures in it, we should be aborting.  If those
failures are ok, then we should be writing better bash code that takes optional failures into
consideration.

> When an export var command fails in launch_container.sh, the full container launch should
fail
> ----------------------------------------------------------------------------------------------
>
>                 Key: YARN-5219
>                 URL: https://issues.apache.org/jira/browse/YARN-5219
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Hitesh Shah
>            Assignee: Sunil G
>         Attachments: YARN-5219-branch-2.001.patch, YARN-5219.001.patch, YARN-5219.003.patch,
YARN-5219.004.patch
>
>
> Today, a container fails if certain files fail to localize. However, if certain env vars
fail to get setup properly either due to bugs in the yarn application or misconfiguration,
the actual process launch still gets triggered. This results in either confusing error messages
if the process fails to launch or worse yet the process launches but then starts behaving
wrongly if the env var is used to control some behavioral aspects. 
> In this scenario, the issue was reproduced by trying to do export abc="$\{foo.bar}" which
is invalid as var names cannot contain "." in bash. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message