Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 14 Dec 2016 23:01:58 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.13027944.1481674573000.524723.1481756518742@Atlassian.JIRA>
In-Reply-To: <JIRA.13027944.1481674573000@Atlassian.JIRA>
References: <JIRA.13027944.1481674573000@Atlassian.JIRA> <JIRA.13027944.1481674573153@arcas>
Subject: [jira] [Commented] (YARN-5999) AMRMClientAsync will stop if any
 exceptions thrown on allocate call
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 14 Dec 2016 23:02:01 -0000


    [ https://issues.apache.org/jira/browse/YARN-5999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749783#comment-15749783 ] 

Hudson commented on YARN-5999:
------------------------------

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10999 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/10999/])
YARN-5999. AMRMClientAsync will stop if any exceptions thrown on (xgong: rev 64a2d5be91a7f344aadf820481c542c967bc46a8)
* (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/async/impl/TestAMRMClientAsync.java
* (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/impl/AMRMClientAsyncImpl.java


> AMRMClientAsync will stop if any exceptions thrown on allocate call 
> --------------------------------------------------------------------
>
>                 Key: YARN-5999
>                 URL: https://issues.apache.org/jira/browse/YARN-5999
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Jian He
>            Assignee: Jian He
>         Attachments: YARN-5999.1.patch
>
>
> Currently, for any exceptions thrown on the allocate call of AMRMClientAsync,  it will stop both heartbeat thread and the callback handler thread, leaving AMRMClient in an unusable state.  Caller has to instantiate a new AMRMClient. 
> IMO, the threads should keep on running, it should be up to the caller whether to stop the AMRMClient or not.
> {code}
>           try {
>             response = client.allocate(progress);
>           } catch (ApplicationAttemptNotFoundException e) {
>             handler.onShutdownRequest();
>             LOG.info("Shutdown requested. Stopping callback.");
>             return;
>           } catch (Throwable ex) {
>             LOG.error("Exception on heartbeat", ex);
>             savedException = ex;
>             // interrupt handler thread in case it waiting on the queue
>             handlerThread.interrupt();
>             return;
>           }
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org