hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arun Suresh (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (YARN-5938) Minor refactoring to OpportunisticContainerAllocatorAMService
Date Tue, 20 Dec 2016 02:42:58 GMT

     [ https://issues.apache.org/jira/browse/YARN-5938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Arun Suresh updated YARN-5938:
    Attachment: YARN-5938-YARN-5085.004.patch

Updating patch based on [~leftnoteasy]'s suggestions.

bq. ApplicationMasterService#allocate -> internalAllocate
I renamed it to {{allocateInternal()}} to maintain consistency with other places such as ContainerManager#startContainerInternal()

> Minor refactoring to OpportunisticContainerAllocatorAMService
> -------------------------------------------------------------
>                 Key: YARN-5938
>                 URL: https://issues.apache.org/jira/browse/YARN-5938
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Arun Suresh
>            Assignee: Arun Suresh
>         Attachments: YARN-5938-YARN-5085.001.patch, YARN-5938-YARN-5085.002.patch, YARN-5938-YARN-5085.003.patch,
YARN-5938-YARN-5085.004.patch, YARN-5938.001.patch
> Minor code re-organization to do the following:
> # The OpportunisticContainerAllocatorAMService currently allocates outside the ApplicationAttempt
lock maintained by the ApplicationMasterService. This should happen inside the lock.
> # Refactored out some code to simplify the allocate() method.
> # Removed some unused fields inside the OpportunisticContainerAllocator.
> # Re-organized some of the code in the OpportunisticContainerAllocatorAMService::allocate
method to make it a bit more readable.
> # Moved SchedulerRequestKey to a new package, so it can be used by the OpportunisticContainerAllocator/Context.
> # Moved all usages of Priority in the OpportunisticContainerAllocator -> SchedulerRequestKey.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org

View raw message