hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sangjin Lee (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5922) Remove direct references of HBaseTimelineWriter/Reader in core ATS classes
Date Fri, 02 Dec 2016 02:38:59 GMT

    [ https://issues.apache.org/jira/browse/YARN-5922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15713815#comment-15713815
] 

Sangjin Lee commented on YARN-5922:
-----------------------------------

Sorry I was assuming incorrectly that these properties were not already in {{yarn-default.xml}}.

The real reason that the test is failing is because these default value definitions in {{YarnConfiguration}}
are mistakenly flagged as *property keys*. You'd need to skip them using {{configurationPropsToSkipCompare}}.
This is how a similar issue is addressed in {{TestYarnConfigurationFields}}:
{code}
    configurationPropsToSkipCompare
        .add(YarnConfiguration.DEFAULT_IPC_RECORD_FACTORY_CLASS);
    configurationPropsToSkipCompare
        .add(YarnConfiguration.DEFAULT_IPC_CLIENT_FACTORY_CLASS);
    configurationPropsToSkipCompare
        .add(YarnConfiguration.DEFAULT_IPC_SERVER_FACTORY_CLASS);
{code}
We should add our 2 default fields to get around this.

> Remove direct references of HBaseTimelineWriter/Reader in core ATS classes
> --------------------------------------------------------------------------
>
>                 Key: YARN-5922
>                 URL: https://issues.apache.org/jira/browse/YARN-5922
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: yarn
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Haibo Chen
>            Assignee: Haibo Chen
>         Attachments: YARN-5922-YARN-5355.01.patch, YARN-5922-YARN-5355.02.patch, YARN-5922.01.patch,
YARN-5922.02.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message