hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karthik Kambatla (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5831) Propagate allowPreemptionFrom flag all the way down to the app
Date Wed, 28 Dec 2016 18:54:58 GMT

    [ https://issues.apache.org/jira/browse/YARN-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15783486#comment-15783486
] 

Karthik Kambatla commented on YARN-5831:
----------------------------------------

Thanks for working on this, Yufei. 

Comments on the patch:
# FSAppAttempt: 
## Should we have a method called isPreemptable() in Schedulable and override it? Also, we
could may be add unit tests for isPreemptable() separately then? 
## canContainerBePreempted(): Nothing to do with this patch, but I wonder if we should check
isPreemptable() first? 
# updatePreemptionVariables refactor: I like the idea of not recursing for updating preemption
variables. 
## We should make sure that queue.init() is called in a pre-order fashion on config update.
Right now, we rely on the iterator (queues.values()). Is that guaranteed to show items in
preorder? 
## How do we guard against future changes where one updates a parent preemption config outside
of config changes and that does not propagate to children? How likely are such changes? Do
we even need to worry about them now? 
## Nothing to do with this patch, but we should likely rename FSQueue#init to FSQueue#reinit?


> Propagate allowPreemptionFrom flag all the way down to the app
> --------------------------------------------------------------
>
>                 Key: YARN-5831
>                 URL: https://issues.apache.org/jira/browse/YARN-5831
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: fairscheduler
>            Reporter: Karthik Kambatla
>            Assignee: Yufei Gu
>         Attachments: YARN-5831.001.patch, YARN-5831.002.patch
>
>
> FairScheduler allows disallowing preemption from a queue. When checking if preemption
for an application is allowed, the new preemption code recurses all the way to the root queue
to check this flag. 
> Propagating this information all the way to the app will be more efficient. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message