hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Trezzo (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5797) Add metrics to the node manager for cleaning the PUBLIC and PRIVATE caches
Date Wed, 14 Dec 2016 18:26:58 GMT

    [ https://issues.apache.org/jira/browse/YARN-5797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749056#comment-15749056
] 

Chris Trezzo commented on YARN-5797:
------------------------------------

The checkstyle warning is because the {{TestResourceLocalizationService#testDownloadingResourcesOnContainerKill}}
 method is over 150 lines:
bq. ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/TestResourceLocalizationService.java:1128:
 @Test(timeout = 20000):3: Method length is 242 lines (max allowed is 150).

This patch barely touches the method (i.e. changes 1 line) so I think it would be wrong to
refactor this method as part of this patch. I will file a jira to address the method refactor.

Thanks!

> Add metrics to the node manager for cleaning the PUBLIC and PRIVATE caches
> --------------------------------------------------------------------------
>
>                 Key: YARN-5797
>                 URL: https://issues.apache.org/jira/browse/YARN-5797
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Chris Trezzo
>            Assignee: Chris Trezzo
>         Attachments: YARN-5797-trunk-v1.patch, YARN-5797-trunk.002.patch
>
>
> Add new metrics to the node manager around the local cache sizes and how much is being
cleaned from them on a regular bases. For example, we can expose information contained in
the {{LocalCacheCleanerStats}} class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message