hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wangda Tan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5774) MR Job stuck in ACCEPTED status without any progress in Fair Scheduler if set yarn.scheduler.minimum-allocation-mb to 0.
Date Tue, 20 Dec 2016 00:23:58 GMT

    [ https://issues.apache.org/jira/browse/YARN-5774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15762745#comment-15762745
] 

Wangda Tan commented on YARN-5774:
----------------------------------

Hi [~yufeigu], [~templedf],

I noticed this change while reviewing YARN-5959. This change looks like an incompatible change
to me, it removed public/stable method from ResourceRequest, which makes API doc different.
And now ResourceRequest (public/stable) inherits from a public/unstable class.

I can understand it is added for making normalizeResource to handle both of updateContainerRequest
/ ResourceRequest. But changing user facing API to simplify internal implementation doesn't
look like a good idea to me.

Instead, I suggest to revert the AbstractResourceRequest change, and update {{void normalizeRequest(AbstractResourceRequest
request);}} to {{Resource getNormalizedResource(Resource askedResource)}} to make "what to
normalize" more clear.

Thoughts?

> MR Job stuck in ACCEPTED status without any progress in Fair Scheduler if set yarn.scheduler.minimum-allocation-mb
to 0.
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-5774
>                 URL: https://issues.apache.org/jira/browse/YARN-5774
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Yufei Gu
>            Assignee: Yufei Gu
>              Labels: oct16-easy
>             Fix For: 2.8.0, 3.0.0-alpha2
>
>         Attachments: YARN-5774.001.patch, YARN-5774.002.patch, YARN-5774.003.patch, YARN-5774.004.patch,
YARN-5774.005.patch, YARN-5774.006.patch, YARN-5774.007.patch
>
>
> MR Job stuck in ACCEPTED status without any progress in Fair Scheduler because there
is no resource request for the AM. This happened when you configure {{yarn.scheduler.minimum-allocation-mb}}
to zero.
> The problem is in the code used by both Capacity Scheduler and Fair Scheduler. {{scheduler.increment-allocation-mb}}
is a concept in FS, but not CS. So the common code in class RMAppManager passes the {{yarn.scheduler.minimum-allocation-mb}}
as incremental one because there is no incremental one for CS when it tried to normalize the
resource requests.
> {code}
>      SchedulerUtils.normalizeRequest(amReq, scheduler.getResourceCalculator(),
>           scheduler.getClusterResource(),
>           scheduler.getMinimumResourceCapability(),
>           scheduler.getMaximumResourceCapability(),
>           scheduler.getMinimumResourceCapability());  --> incrementResource should
be passed here.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message