hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Varun Saxena (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5585) [Atsv2] Reader side changes for entity prefix and support for pagination via additional filters
Date Wed, 21 Dec 2016 14:40:58 GMT

    [ https://issues.apache.org/jira/browse/YARN-5585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15767212#comment-15767212
] 

Varun Saxena commented on YARN-5585:
------------------------------------

bq. This would also require to change TimelineEntity equals method comparing idprefix also.

Probably not. Infact if we do not compare id prefix, equals will help us determine if a duplicate
entity is being added (with same entity id and type) while adding it to LinkedHashSet. We
can hence throw an exception (if we agree upon it) if duplicate entity is added. This can
be done in TimelineEntityReader class. My intention was to keep it consistent with get entity
call but this can have a disadvantage of not returning anything if even one entity is duplicate.
Another option would be to wrap the list of timeline entities inside another class. And this
class can additionally contain a list of error entities which are duplicate to alert the user.
This can be returned in HTTP response of get entities call.
We can see what the majority opinion on this though. Li, your thoughts on this ?

bq. We can have one wrapper for method createHBaseSingleColValueFilter that takes input as
column.
Yeah probably can do so.

bq. Shall we avoid using those constants? We can set an enum to represent each part of the
tuple list.
Which constants are we talking about here ? Delimiters ?



> [Atsv2] Reader side changes for entity prefix and support for pagination via additional
filters
> -----------------------------------------------------------------------------------------------
>
>                 Key: YARN-5585
>                 URL: https://issues.apache.org/jira/browse/YARN-5585
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelinereader
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>            Priority: Critical
>              Labels: yarn-5355-merge-blocker
>         Attachments: 0001-YARN-5585.patch, YARN-5585-YARN-5355.0001.patch, YARN-5585-YARN-5355.0002.patch,
YARN-5585-YARN-5355.0003.patch, YARN-5585-workaround.patch, YARN-5585.v0.patch
>
>
> TimelineReader REST API's provides lot of filters to retrieve the applications. Along
with those, it would be good to add new filter i.e fromId so that entities can be retrieved
after the fromId. 
> Current Behavior : Default limit is set to 100. If there are 1000 entities then REST
call gives first/last 100 entities. How to retrieve next set of 100 entities i.e 101 to 200
OR 900 to 801?
> Example : If applications are stored database, app-1 app-2 ... app-10.
> *getApps?limit=5* gives app-1 to app-5. But to retrieve next 5 apps, there is no way
to achieve this. 
> So proposal is to have fromId in the filter like *getApps?limit=5&&fromId=app-5*
which gives list of apps from app-6 to app-10. 
> Since ATS is targeting large number of entities storage, it is very common use case to
get next set of entities using fromId rather than querying all the entites. This is very useful
for pagination in web UI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message