hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Li Lu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-4675) Reorganize TimeClientImpl into TimeClientV1Impl and TimeClientV2Impl
Date Tue, 06 Dec 2016 21:31:59 GMT

    [ https://issues.apache.org/jira/browse/YARN-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15726776#comment-15726776
] 

Li Lu commented on YARN-4675:
-----------------------------

I'm fine with separating the v1 and v2 interfaces. Right now mixing v1 and v2 interfaces in
one interface looks pretty confusing to me. Since we've decided timeline v2 is not backward
compatible at the very beginning, I think it's fine to let users choose between TimelineClient
v1 and v2. 

bq. things that are referencing TimelineClientImpl directly today
Yes, we should not directly refer to TimelineClientImpl in downstream usages. Shall I open
a JIRA and remove all of them? 

bq.  the facility for getting delegation token and renewing it would be common to both the
clients. We would not want to repeat such large amounts of code in both V1 and V2 client implementations.

That's certainly a very valid concern, and addressing this may bring in much discussions on
security itself. My bottomline here is that let's *assume* any security facilities do not
exist in timeline v2, and let's start the design from the scratch. We may then think about
how to merge and reuse the code afterwards. For now, let's not think about maximize code reuse
for timeline v1 and v2, especially for security? 

> Reorganize TimeClientImpl into TimeClientV1Impl and TimeClientV2Impl
> --------------------------------------------------------------------
>
>                 Key: YARN-4675
>                 URL: https://issues.apache.org/jira/browse/YARN-4675
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>              Labels: YARN-5355, oct16-medium
>         Attachments: YARN-4675-YARN-2928.v1.001.patch
>
>
> We need to reorganize TimeClientImpl into TimeClientV1Impl ,  TimeClientV2Impl and if
required a base class, so that its clear which part of the code belongs to which version and
thus better maintainable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message