Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A8C21200BF3 for ; Wed, 30 Nov 2016 17:24:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id A7802160B19; Wed, 30 Nov 2016 16:24:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E8EB6160B28 for ; Wed, 30 Nov 2016 17:23:59 +0100 (CET) Received: (qmail 99068 invoked by uid 500); 30 Nov 2016 16:23:58 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 98819 invoked by uid 99); 30 Nov 2016 16:23:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Nov 2016 16:23:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 918452C2A6C for ; Wed, 30 Nov 2016 16:23:58 +0000 (UTC) Date: Wed, 30 Nov 2016 16:23:58 +0000 (UTC) From: "Weiwei Yang (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-5939) Disabling the cache of FileSystem leads to case that never close the FileSystem MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 30 Nov 2016 16:24:00 -0000 [ https://issues.apache.org/jira/browse/YARN-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15709021#comment-15709021 ] Weiwei Yang commented on YARN-5939: ----------------------------------- Hello [~knoguchi] Would you like to help to review this patch? Thanks a lot. > Disabling the cache of FileSystem leads to case that never close the FileSystem > ------------------------------------------------------------------------------- > > Key: YARN-5939 > URL: https://issues.apache.org/jira/browse/YARN-5939 > Project: Hadoop YARN > Issue Type: Bug > Components: nodemanager > Affects Versions: 2.5.1, 2.7.3 > Reporter: liuxiangwei > Assignee: Weiwei Yang > Attachments: YARN-5939.01.patch, YARN-5939.02.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > Background > To use our self-defined FileSystem class, the item of configuration "fs.%s.impl.disable.cache" should set to true. > In YARN's source code, the class named "org.apache.hadoop.yarn.util.FSDownload" use getFileSystem but never close, which leading to file descriptor leak because our self-defined FileSystem class close the file descriptor when the close function is invoked. > My Question below: > 1. whether invoking "getFileSystem" but never close is YARN's expected behavior > 2. what should we do in our self-defined FileSystem resolve it. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org