Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4846C200BC5 for ; Tue, 22 Nov 2016 12:54:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 46FC8160B0C; Tue, 22 Nov 2016 11:54:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B60C8160B0A for ; Tue, 22 Nov 2016 12:53:59 +0100 (CET) Received: (qmail 28215 invoked by uid 500); 22 Nov 2016 11:53:58 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 28204 invoked by uid 99); 22 Nov 2016 11:53:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Nov 2016 11:53:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 8A5052C4C75 for ; Tue, 22 Nov 2016 11:53:58 +0000 (UTC) Date: Tue, 22 Nov 2016 11:53:58 +0000 (UTC) From: "Naganarasimha G R (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-5911) DrainDispatcher does not drain all events on stop even if setDrainEventsOnStop is true MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 22 Nov 2016 11:54:00 -0000 [ https://issues.apache.org/jira/browse/YARN-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15686532#comment-15686532 ] Naganarasimha G R commented on YARN-5911: ----------------------------------------- Thanks [~varun_saxena], Patch looks fine and will commit it shortly ! > DrainDispatcher does not drain all events on stop even if setDrainEventsOnStop is true > -------------------------------------------------------------------------------------- > > Key: YARN-5911 > URL: https://issues.apache.org/jira/browse/YARN-5911 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Varun Saxena > Assignee: Varun Saxena > Attachments: YARN-5911.01.patch, YARN-5911.02.patch > > > DrainDispatcher#serviceStop sets the stopped flag first before draining the event queue. > This means that the thread terminates as soon as it encounters stopped flag as true and does not continue to process leftover events in queue, something which it should do if setDrainEventsOnStop is set. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org