Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 21 Nov 2016 09:04:59 +0000 (UTC)
From: "Varun Saxena (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.13021682.1479449838000.325499.1479719099480@Atlassian.JIRA>
In-Reply-To: <JIRA.13021682.1479449838000@Atlassian.JIRA>
References: <JIRA.13021682.1479449838000@Atlassian.JIRA> <JIRA.13021682.1479449838017@arcas>
Subject: [jira] [Commented] (YARN-5911) DrainDispatcher does not drain all
 events on stop even if setDrainEventsOnStop is true
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 21 Nov 2016 09:05:01 -0000


    [ https://issues.apache.org/jira/browse/YARN-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15682941#comment-15682941 ] 

Varun Saxena commented on YARN-5911:
------------------------------------

Thanks sandflee and Bibin for review.
You are correct. We can probably use notify in DrainDispatcher as well but a timeout of 100 ms. should just do as well for tests. Reduced timeout to 100 ms. during wait.
Also changed the name of test method.

> DrainDispatcher does not drain all events on stop even if setDrainEventsOnStop is true
> --------------------------------------------------------------------------------------
>
>                 Key: YARN-5911
>                 URL: https://issues.apache.org/jira/browse/YARN-5911
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>         Attachments: YARN-5911.01.patch, YARN-5911.02.patch
>
>
> DrainDispatcher#serviceStop sets the stopped flag first before draining the event queue.
> This means that the thread terminates as soon as it encounters stopped flag as true and does not continue to process leftover events in queue, something which it should do if setDrainEventsOnStop is set.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org