Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 10 Nov 2016 22:17:59 +0000 (UTC)
From: "Karthik Kambatla (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.13017889.1478221395000.248803.1478816279389@Atlassian.JIRA>
In-Reply-To: <JIRA.13017889.1478221395000@Atlassian.JIRA>
References: <JIRA.13017889.1478221395000@Atlassian.JIRA> <JIRA.13017889.1478221395425@arcas>
Subject: [jira] [Updated] (YARN-5834)
 TestNodeStatusUpdater.testNMRMConnectionConf compares nodemanager wait time
 to the incorrect value
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 10 Nov 2016 22:18:01 -0000


     [ https://issues.apache.org/jira/browse/YARN-5834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Karthik Kambatla updated YARN-5834:
-----------------------------------
    Fix Version/s: 3.0.0-alpha2

> TestNodeStatusUpdater.testNMRMConnectionConf compares nodemanager wait time to the incorrect value
> --------------------------------------------------------------------------------------------------
>
>                 Key: YARN-5834
>                 URL: https://issues.apache.org/jira/browse/YARN-5834
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Miklos Szegedi
>            Assignee: Chang Li
>            Priority: Trivial
>             Fix For: 2.9.0, 3.0.0-alpha2
>
>         Attachments: YARN-5834-branch-2.001.patch
>
>
> The function is TestNodeStatusUpdater#testNMRMConnectionConf()
> I believe the connectionWaitMs references below were meant to be nmRmConnectionWaitMs.
> {code}
>     conf.setLong(YarnConfiguration.NM_RESOURCEMANAGER_CONNECT_MAX_WAIT_MS,
>         nmRmConnectionWaitMs);
> conf.setLong(YarnConfiguration.RESOURCEMANAGER_CONNECT_MAX_WAIT_MS,
>         connectionWaitMs);
> ...
>       long t = System.currentTimeMillis();
>       long duration = t - waitStartTime;
>       boolean waitTimeValid = (duration >= nmRmConnectionWaitMs) &&
>           (duration < (*connectionWaitMs* + delta));
>       if(!waitTimeValid) {
>         // throw exception if NM doesn't retry long enough
>         throw new Exception("NM should have tried re-connecting to RM during " +
>           "period of at least " + *connectionWaitMs* + " ms, but " +
>           "stopped retrying within " + (*connectionWaitMs* + delta) +
>           " ms: " + e, e);
>       }
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org