Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 922E1200BCA for ; Mon, 7 Nov 2016 07:01:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 90C99160B0D; Mon, 7 Nov 2016 06:01:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D908F160AFC for ; Mon, 7 Nov 2016 07:01:05 +0100 (CET) Received: (qmail 22818 invoked by uid 500); 7 Nov 2016 06:01:05 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 22807 invoked by uid 99); 7 Nov 2016 06:01:04 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Nov 2016 06:01:04 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 9D3382C2A6E for ; Mon, 7 Nov 2016 06:01:04 +0000 (UTC) Date: Mon, 7 Nov 2016 06:01:04 +0000 (UTC) From: "Sunil G (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-5820) yarn node CLI help should be clearer MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 07 Nov 2016 06:01:06 -0000 [ https://issues.apache.org/jira/browse/YARN-5820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15643221#comment-15643221 ] Sunil G commented on YARN-5820: ------------------------------- [~ajithshetty] Than for the patch. Few nits - In below code, {noformat} pw.println( "usage: node [-list [-states |-showDetails|-all] |-status ]"); {noformat} Suboptions of {{node -list}} could be displayed in alphabetical order with *-all* at start (currently all options in help are displayed in alphabetical) - I am not sure whether to show *-help* also there. Clearly we are showing -help below. There are no strong arguments for that, but more thoughts are welcome. > yarn node CLI help should be clearer > ------------------------------------ > > Key: YARN-5820 > URL: https://issues.apache.org/jira/browse/YARN-5820 > Project: Hadoop YARN > Issue Type: Bug > Components: client > Affects Versions: 2.6.0 > Reporter: Grant Sohn > Assignee: Ajith S > Priority: Trivial > Attachments: YARN-5820.01.patch, YARN-5820.02.patch, YARN-5820.03.patch > > > Current message is: > {noformat} > usage: node > -all Works with -list to list all nodes. > -list List all running nodes. Supports optional use of > -states to filter nodes based on node state, all -all > to list all nodes. > -states Works with -list to filter nodes based on input > comma-separated list of node states. > -status Prints the status report of the node. > {noformat} > It should be either this: > {noformat} > usage: yarn node [-list [-states |-all] | -status ] > -all Works with -list to list all nodes. > -list List all running nodes. Supports optional use of > -states to filter nodes based on node state, all -all > to list all nodes. > -states Works with -list to filter nodes based on input > comma-separated list of node states. > -status Prints the status report of the node. > {noformat} > or that. > {noformat} > usage: yarn node -list [-states |-all] > yarn node -status > -all Works with -list to list all nodes. > -list List all running nodes. Supports optional use of > -states to filter nodes based on node state, all -all > to list all nodes. > -states Works with -list to filter nodes based on input > comma-separated list of node states. > -status Prints the status report of the node. > {noformat} > The latter is the least ambiguous. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org