Return-Path: <yarn-issues-return-101725-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 36212200BC2
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Thu, 17 Nov 2016 15:49:00 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 34F7B160B0B; Thu, 17 Nov 2016 14:49:00 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 7FD40160AFF
	for <archive-asf-public@cust-asf.ponee.io>; Thu, 17 Nov 2016 15:48:59 +0100 (CET)
Received: (qmail 5342 invoked by uid 500); 17 Nov 2016 14:48:58 -0000
Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:yarn-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:yarn-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:yarn-issues@hadoop.apache.org>
List-Id: <yarn-issues.hadoop.apache.org>
Delivered-To: mailing list yarn-issues@hadoop.apache.org
Received: (qmail 5313 invoked by uid 99); 17 Nov 2016 14:48:58 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Nov 2016 14:48:58 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 5FEEB2C0D55
	for <yarn-issues@hadoop.apache.org>; Thu, 17 Nov 2016 14:48:58 +0000 (UTC)
Date: Thu, 17 Nov 2016 14:48:58 +0000 (UTC)
From: "Daniel Templeton (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.13014040.1476995388000.304056.1479394138389@Atlassian.JIRA>
In-Reply-To: <JIRA.13014040.1476995388000@Atlassian.JIRA>
References: <JIRA.13014040.1476995388000@Atlassian.JIRA> <JIRA.13014040.1476995388124@arcas>
Subject: [jira] [Comment Edited] (YARN-5761) Separate QueueManager from
 Scheduler
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Thu, 17 Nov 2016 14:49:00 -0000


    [ https://issues.apache.org/jira/browse/YARN-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15673900#comment-15673900 ] 

Daniel Templeton edited comment on YARN-5761 at 11/17/16 2:48 PM:
------------------------------------------------------------------

Couple of comments:

* {{SchedulerQueueManager}} should have explanatory javadocs on all its methods.
* {{CapacitySchedulerQueueManager.queues}} should be final; use the diamond operator; and be called {{QUEUES}}.
* Missing javadoc in public constructor and many methods.
* Extra space in: {code}    root =  parseQueue(this.csContext, conf, null,{code}
* Should use diamond operator here: {code}    Map<String, CSQueue> newQueues = new HashMap<String, CSQueue>();{code}, here: {code}      List<CSQueue> childQueues = new ArrayList<CSQueue>();{code} and here: {code}    Map<String, Set<String>> queueToLabels = new HashMap<
        String, Set<String>>();{code}
* These two lines can be concatenated: {code}    String[] childQueueNames =
      conf.getQueues(fullQueueName);{code}
* {{throws}} has wrong indentation: {code}  private void validateExistingQueues(
      Map<String, CSQueue> queues, Map<String, CSQueue> newQueues)
  throws IOException {{code}
* {{addNewQueues()}} is missing descriptions for its params in javadoc.
* This {{@throws}} message is devoid of information: {{@throws YarnException in case of errors}}. In case of what kind of errors?





was (Author: templedf):
Couple of comments

* {{CapacitySchedulerQueueManager.queues}} should be final; use the diamond operator; and be called {{QUEUES}}.
* Missing javadoc in public constructor and methods
* Extra space in: {code}    root =  parseQueue(this.csContext, conf, null,{code}
* Should use diamond operator here: {code}    Map<String, CSQueue> newQueues = new HashMap<String, CSQueue>();{code}, here: {code}      List<CSQueue> childQueues = new ArrayList<CSQueue>();{code} and here: {code}    Map<String, Set<String>> queueToLabels = new HashMap<
        String, Set<String>>();{code}
* These two lines can be concatenated: {code}    String[] childQueueNames =
      conf.getQueues(fullQueueName);{code}
* {{throws}} has wrong indentation: {code}  private void validateExistingQueues(
      Map<String, CSQueue> queues, Map<String, CSQueue> newQueues)
  throws IOException {{code}
* {{addNewQueues()}} is missing descriptions for its params in javadoc.
* This {{@throws}} message is devoid of information: {{@throws YarnException in case of errors}}. In case of what kind of errors?




> Separate QueueManager from Scheduler
> ------------------------------------
>
>                 Key: YARN-5761
>                 URL: https://issues.apache.org/jira/browse/YARN-5761
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacityscheduler
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>              Labels: oct16-medium
>         Attachments: YARN-5761.1.patch, YARN-5761.1.rebase.patch, YARN-5761.2.patch, YARN-5761.3.patch, YARN-5761.4.patch, YARN-5761.5.patch
>
>
> Currently, in scheduler code, we are doing queue manager and scheduling work. 
> We'd better separate the queue manager out of scheduler logic. In that case, it would be much easier and safer to extend.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org