Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 21 Nov 2016 12:05:00 +0000 (UTC)
From: "Varun Saxena (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12998960.1471887993000.327443.1479729900024@Atlassian.JIRA>
In-Reply-To: <JIRA.12998960.1471887993000@Atlassian.JIRA>
References: <JIRA.12998960.1471887993000@Atlassian.JIRA> <JIRA.12998960.1471887993414@arcas>
Subject: [jira] [Commented] (YARN-5548) Use MockRMMemoryStateStore to reduce
 test failures
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 21 Nov 2016 12:05:02 -0000


    [ https://issues.apache.org/jira/browse/YARN-5548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15683412#comment-15683412 ] 

Varun Saxena commented on YARN-5548:
------------------------------------

Thanks [~bibinchundatt] for the patch.
Looking at it from the point of view of test failures, at many places we do not really need a MockRMMemoryStateStore as we wait on RMApp state which we transition to, after processing of state store event.
But I cannot really see where in tests, a dispatcher for state store events will be necessary. For most tests, arguably, processing the event straight away may be faster then letting AsyncDispatcher thread pick it up because our tests will most probably be processing one app at a time and lock contention on state store is unlikely to happen. So I think we can pretty much use MockRMMemoryStateStore everywhere. Should we rename it to something else as we have moved this class outside MockRM ? However, I am fine to keep this name also if a suitable name cannot be thought of.

There are still some tests where we are still using MemoryRMStateStore, for instance, TestNodeBlacklistingOnAMFailures. We use the new version of memory state store there ?

> Use MockRMMemoryStateStore to reduce test failures
> --------------------------------------------------
>
>                 Key: YARN-5548
>                 URL: https://issues.apache.org/jira/browse/YARN-5548
>             Project: Hadoop YARN
>          Issue Type: Test
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>              Labels: oct16-easy, test
>         Attachments: YARN-5548.0001.patch, YARN-5548.0002.patch, YARN-5548.0003.patch, YARN-5548.0004.patch, YARN-5548.0005.patch, YARN-5548.0006.patch, YARN-5548.0007.patch
>
>
> https://builds.apache.org/job/PreCommit-YARN-Build/12850/testReport/org.apache.hadoop.yarn.server.resourcemanager/TestRMRestart/testFinishedAppRemovalAfterRMRestart/
> {noformat}
> Error Message
> Stacktrace
> java.lang.AssertionError: expected null, but was:<submit_time: 1471885197416 application_submission_context { application_id { id: 1 cluster_timestamp: 1471885197388 } application_name: "" queue: "default" priority { priority: 0 } am_container_spec { } cancel_tokens_when_complete: true maxAppAttempts: 2 resource { memory: 1024 virtual_cores: 1 } applicationType: "YARN" keep_containers_across_application_attempts: false attempt_failures_validity_interval: 0 am_container_resource_request { priority { priority: 0 } resource_name: "*" capability { memory: 1024 virtual_cores: 1 } num_containers: 0 relax_locality: true node_label_expression: "" execution_type_request { execution_type: GUARANTEED enforce_execution_type: false } } } user: "jenkins" start_time: 1471885197417 application_state: RMAPP_FINISHED finish_time: 1471885197478>
> 	at org.junit.Assert.fail(Assert.java:88)
> 	at org.junit.Assert.failNotNull(Assert.java:664)
> 	at org.junit.Assert.assertNull(Assert.java:646)
> 	at org.junit.Assert.assertNull(Assert.java:656)
> 	at org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart.testFinishedAppRemovalAfterRMRestart(TestRMRestart.java:1656)
> {noformat}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org