Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Sun, 13 Nov 2016 12:34:58 +0000 (UTC)
From: "Naganarasimha G R (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.12998925.1471879375000.263602.1479040498505@Atlassian.JIRA>
In-Reply-To: <JIRA.12998925.1471879375000@Atlassian.JIRA>
References: <JIRA.12998925.1471879375000@Atlassian.JIRA> <JIRA.12998925.1471879375511@arcas>
Subject: [jira] [Commented] (YARN-5547) NMLeveldbStateStore should be more
 tolerant of unknown keys
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sun, 13 Nov 2016 12:35:00 -0000


    [ https://issues.apache.org/jira/browse/YARN-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15661426#comment-15661426 ] 

Naganarasimha G R commented on YARN-5547:
-----------------------------------------

Thanks [~ajithshetty] for the patch, Seems like overall approach is fine, and patch is fine to be committed. Would wait for a day more before committing so that others can review.
cc/ [~jlowe].

> NMLeveldbStateStore should be more tolerant of unknown keys
> -----------------------------------------------------------
>
>                 Key: YARN-5547
>                 URL: https://issues.apache.org/jira/browse/YARN-5547
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: nodemanager
>    Affects Versions: 2.6.0
>            Reporter: Jason Lowe
>            Assignee: Ajith S
>         Attachments: YARN-5547.01.patch, YARN-5547.02.patch, YARN-5547.03.patch
>
>
> Whenever new keys are added to the NM state store it will break rolling downgrades because the code will throw if it encounters an unrecognized key.  If instead it skipped unrecognized keys it could be simpler to continue supporting rolling downgrades.  We need to define the semantics of unrecognized keys when containers and apps are cleaned up, e.g.: we may want to delete all keys underneath an app or container directory when it is being removed from the state store to prevent leaking unrecognized keys.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org