hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira Ajisaka (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5934) Fix TestTimelineWebServices.testPrimaryFilterNumericString
Date Thu, 24 Nov 2016 08:01:58 GMT

    [ https://issues.apache.org/jira/browse/YARN-5934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15692576#comment-15692576

Akira Ajisaka commented on YARN-5934:

It looks like Jackson1 parses 123abc to 123, on the other hand, Jackson2 parses 123abc to
"123abc". YARN-3723 documented that Jackson library decides how the value is casted, so I'm
think we can remove the tests.

bq. Note that the value of the key/value pair for primaryFilter and secondaryFilters parameters
can be of different data types, and matching is data type sensitive. Users need to format
the value properly. For example, 123 and "123" means an integer and a string respectively.
If the entity has a string "123" for primaryFilter, but the parameter is set to the integer
123, the entity will not be matched. Similarly, true means a boolean while "true" means a
string. In general, the value will be casted as a certain Java type in consistent with jackson
library parsing a JSON clip.

What do you think, [~stevel@apache.org], [~zjshen], and [~xgong]?

> Fix TestTimelineWebServices.testPrimaryFilterNumericString
> ----------------------------------------------------------
>                 Key: YARN-5934
>                 URL: https://issues.apache.org/jira/browse/YARN-5934
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: test
>            Reporter: Akira Ajisaka
> {noformat}
> Running org.apache.hadoop.yarn.server.timeline.webapp.TestTimelineWebServices
> Tests run: 28, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 43.297 sec <<<
FAILURE! - in org.apache.hadoop.yarn.server.timeline.webapp.TestTimelineWebServices
> testPrimaryFilterNumericString(org.apache.hadoop.yarn.server.timeline.webapp.TestTimelineWebServices)
 Time elapsed: 1.209 sec  <<< FAILURE!
> java.lang.AssertionError: expected:<0> but was:<3>
> 	at org.junit.Assert.fail(Assert.java:88)
> 	at org.junit.Assert.failNotEquals(Assert.java:743)
> 	at org.junit.Assert.assertEquals(Assert.java:118)
> 	at org.junit.Assert.assertEquals(Assert.java:555)
> 	at org.junit.Assert.assertEquals(Assert.java:542)
> 	at org.apache.hadoop.yarn.server.timeline.webapp.TestTimelineWebServices.testPrimaryFilterNumericString(TestTimelineWebServices.java:348)
> {noformat}

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org

View raw message