hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bibin A Chundatt (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5911) DrainDispatcher does not drain all events on stop even if setDrainEventsOnStop is true
Date Fri, 18 Nov 2016 16:31:58 GMT

    [ https://issues.apache.org/jira/browse/YARN-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15677090#comment-15677090
] 

Bibin A Chundatt commented on YARN-5911:
----------------------------------------

Thank you [~varun_saxena] for  jira.
Overall patch looks good to me. Minor comment.
# Rename the test to {{testDrainDispatcherDrainEventsOnStop}} to make testcase more clear.


> DrainDispatcher does not drain all events on stop even if setDrainEventsOnStop is true
> --------------------------------------------------------------------------------------
>
>                 Key: YARN-5911
>                 URL: https://issues.apache.org/jira/browse/YARN-5911
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>         Attachments: YARN-5911.01.patch
>
>
> DrainDispatcher#serviceStop sets the stopped flag first before draining the event queue.
> This means that the thread terminates as soon as it encounters stopped flag as true and
does not continue to process leftover events in queue, something which it should do if setDrainEventsOnStop
is set.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message