hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohith Sharma K S (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5865) Retrospect updateApplicationPriority api to handle state store exception in align with YARN-5611
Date Mon, 14 Nov 2016 06:26:58 GMT

    [ https://issues.apache.org/jira/browse/YARN-5865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15662917#comment-15662917
] 

Rohith Sharma K S commented on YARN-5865:
-----------------------------------------

Thanks Sunil for the patch.. couple of things to consider, 
# As Jian comment, need to update state-store first and update in-memory second. But this
would be difficult in priority update as it try to update ApplicationSubmissionContext. I
think this is time to think for storing priority in ApplicaitonStateData. As I see storing
priority as separate field in ApplicationStateData would be a difficult for priority update
to change some of the implementation part especially during submission and recovery flow,
but I think it is good to do it now. Thoughts? 
# I see one race conditional bug since we are holding lock on applicationId. Could we do {{if
(COMPLETED_APP_STATES.contains(application.getState())) {}} check either after holding lock
of applicationId or in method {{RMStateStore#updateApplicationStateSynchronously}} ??

> Retrospect updateApplicationPriority api to handle state store exception in align with
YARN-5611
> ------------------------------------------------------------------------------------------------
>
>                 Key: YARN-5865
>                 URL: https://issues.apache.org/jira/browse/YARN-5865
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Sunil G
>            Assignee: Sunil G
>         Attachments: YARN-5865.0001.patch
>
>
> Post YARN-5611, revisit dynamic update of application priority logic with respect to
state store error handling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message