hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5834) TestNodeStatusUpdater.testNMRMConnectionConf compares nodemanager wait time to the incorrect value
Date Thu, 10 Nov 2016 22:22:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-5834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15655347#comment-15655347
] 

Hudson commented on YARN-5834:
------------------------------

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10814 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/10814/])
YARN-5834. TestNodeStatusUpdater.testNMRMConnectionConf compares (kasha: rev 3a98419532687e4362ffc26abbc1264232820db7)
* (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java


> TestNodeStatusUpdater.testNMRMConnectionConf compares nodemanager wait time to the incorrect
value
> --------------------------------------------------------------------------------------------------
>
>                 Key: YARN-5834
>                 URL: https://issues.apache.org/jira/browse/YARN-5834
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Miklos Szegedi
>            Assignee: Chang Li
>            Priority: Trivial
>             Fix For: 2.9.0, 3.0.0-alpha2
>
>         Attachments: YARN-5834-branch-2.001.patch
>
>
> The function is TestNodeStatusUpdater#testNMRMConnectionConf()
> I believe the connectionWaitMs references below were meant to be nmRmConnectionWaitMs.
> {code}
>     conf.setLong(YarnConfiguration.NM_RESOURCEMANAGER_CONNECT_MAX_WAIT_MS,
>         nmRmConnectionWaitMs);
> conf.setLong(YarnConfiguration.RESOURCEMANAGER_CONNECT_MAX_WAIT_MS,
>         connectionWaitMs);
> ...
>       long t = System.currentTimeMillis();
>       long duration = t - waitStartTime;
>       boolean waitTimeValid = (duration >= nmRmConnectionWaitMs) &&
>           (duration < (*connectionWaitMs* + delta));
>       if(!waitTimeValid) {
>         // throw exception if NM doesn't retry long enough
>         throw new Exception("NM should have tried re-connecting to RM during " +
>           "period of at least " + *connectionWaitMs* + " ms, but " +
>           "stopped retrying within " + (*connectionWaitMs* + delta) +
>           " ms: " + e, e);
>       }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message