hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sunil G (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5820) yarn node CLI help should be clearer
Date Mon, 07 Nov 2016 06:01:04 GMT

    [ https://issues.apache.org/jira/browse/YARN-5820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15643221#comment-15643221
] 

Sunil G commented on YARN-5820:
-------------------------------

[~ajithshetty]

Than for the patch. Few nits
- In below code,
{noformat}
	    pw.println(
	        "usage: node [-list [-states <States>|-showDetails|-all] |-status <NodeId>]");
{noformat}
Suboptions of {{node -list}} could be displayed in alphabetical order with *-all* at start
(currently all options in help are displayed in alphabetical)
- I am not sure whether to show *-help*  also there. Clearly we are showing -help below. There
are no strong arguments for that, but more thoughts are welcome.

> yarn node CLI help should be clearer
> ------------------------------------
>
>                 Key: YARN-5820
>                 URL: https://issues.apache.org/jira/browse/YARN-5820
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 2.6.0
>            Reporter: Grant Sohn
>            Assignee: Ajith S
>            Priority: Trivial
>         Attachments: YARN-5820.01.patch, YARN-5820.02.patch, YARN-5820.03.patch
>
>
> Current message is:
> {noformat}
> usage: node
>  -all               Works with -list to list all nodes.
>  -list              List all running nodes. Supports optional use of
>                     -states to filter nodes based on node state, all -all
>                     to list all nodes.
>  -states <States>   Works with -list to filter nodes based on input
>                     comma-separated list of node states.
>  -status <NodeId>   Prints the status report of the node.
> {noformat}
> It should be either this:
> {noformat}
> usage: yarn node [-list [-states <States>|-all] | -status <NodeId>]
>  -all               Works with -list to list all nodes.
>  -list              List all running nodes. Supports optional use of
>                     -states to filter nodes based on node state, all -all
>                     to list all nodes.
>  -states <States>   Works with -list to filter nodes based on input
>                     comma-separated list of node states.
>  -status <NodeId>   Prints the status report of the node.
> {noformat}
> or that.
> {noformat}
> usage: yarn node -list [-states <States>|-all] 
>        yarn node -status <NodeId>
>  -all               Works with -list to list all nodes.
>  -list              List all running nodes. Supports optional use of
>                     -states to filter nodes based on node state, all -all
>                     to list all nodes.
>  -states <States>   Works with -list to filter nodes based on input
>                     comma-separated list of node states.
>  -status <NodeId>   Prints the status report of the node.
> {noformat}
> The latter is the least ambiguous.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message