hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sunil G (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5802) Application priority updates add pending apps to running ordering policy
Date Wed, 02 Nov 2016 07:37:59 GMT

    [ https://issues.apache.org/jira/browse/YARN-5802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15628073#comment-15628073
] 

Sunil G commented on YARN-5802:
-------------------------------

Thanks [~bibinchundatt]. One last pass over the  patch. Few minor nits
TestClientRMService.java:
1. testUpdatePriorityAndKillWithEmptyResource -> testUpdatePriorityAndKillAppWithZeroNodes
(or ZeroClusterResource)

TestApplicationPriority.java:
2. testUpdatePriorityAndRemoveAttempt -> testUpdatePriorityOnPendingAppAndKillAttempt
3. This code {{CSQueue defaultQueue = findQueue(rootQueue, "root.default”);}} could be replaced
with {{LeafQueue q = (LeafQueue) cs.getQueue("default");}} given that the scheduler is CS.
If so we could remove {{findQueue}}
4. In {{killAppAndVerifyOrderingPolicy}}, *appsPending* and *activeApps* are calculated before
calling {{updateApplicationPriority}}. Pls retrieve these values after update and kill event.

5. In {{killAppAndVerifyOrderingPolicy}},  *activeApps* is directly getting an object of *schedulableEntities*.
pls use *getApplications* from LeafQueue like pending.

> Application priority updates add pending apps to running ordering policy
> ------------------------------------------------------------------------
>
>                 Key: YARN-5802
>                 URL: https://issues.apache.org/jira/browse/YARN-5802
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>            Priority: Critical
>         Attachments: YARN-5802.0001.patch, YARN-5802.0002.patch, YARN-5802.0003.patch,
YARN-5802.0004.patch, YARN-5802.0005.patch
>
>
> {{LeafQueue#updateApplicationPriority}}
> {code}
>  getOrderingPolicy().removeSchedulableEntity(attempt);
>       // Update new priority in SchedulerApplication
>       attempt.setPriority(newAppPriority);
>       getOrderingPolicy().addSchedulableEntity(attempt);
> {code}
> We should add again to ordering policy only when  attempt available in first case.Else
during application attempt removal will try to iterate on killed application still available
in pending Ordering policy.Which can cause RM to crash.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message