hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sangjin Lee (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5792) adopt the id prefix for YARN, MR, and DS entities
Date Wed, 16 Nov 2016 23:28:59 GMT

    [ https://issues.apache.org/jira/browse/YARN-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15672049#comment-15672049
] 

Sangjin Lee commented on YARN-5792:
-----------------------------------

Thanks [~varun_saxena] for updating the patch! I think it's almost there.

One minor nit: The (first) javadoc sentence should be in the third person. For example, it
should say "Gets the task attempt start time" instead of "Get the task attempt start time".
Could you check the javadoc we're adding in this patch and correct them?

Can others please review this patch? Thanks!

> adopt the id prefix for YARN, MR, and DS entities
> -------------------------------------------------
>
>                 Key: YARN-5792
>                 URL: https://issues.apache.org/jira/browse/YARN-5792
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-5355
>            Reporter: Sangjin Lee
>            Assignee: Varun Saxena
>         Attachments: YARN-5792-YARN-5355.01.patch, YARN-5792-YARN-5355.02.patch, YARN-5792-YARN-5355.03.patch,
YARN-5792-YARN-5355.04.patch, YARN-5792-YARN-5355.05.patch
>
>
> We introduced the entity id prefix to support flexible entity sorting (YARN-5715). We
should adopt the id prefix for YARN entities, MR entities, and DS entities to take advantage
of the id prefix.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message