hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Templeton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5783) Verify applications are identified starved
Date Thu, 03 Nov 2016 22:27:58 GMT

    [ https://issues.apache.org/jira/browse/YARN-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15634515#comment-15634515
] 

Daniel Templeton commented on YARN-5783:
----------------------------------------

Comments:

* In {{SchedulerApplicationAttempt.hashCode()}}, what is the value of adding the prime \*
positive?
* In {{FSStarvedApps.take()}} javadoc you don't need the hyphen in the @throws message.
* In {{TestFSAppsStarvation}} test methods, should {code}    setupStarvedCluster();
    submitAppsToEachLeafQueue();
    sendNodeUpdateEvents();

    // Sleep to hit the preemption timeouts
    Thread.sleep(10);

    // Scheduler update to populate starved apps
    scheduler.update();

    // Wait for apps to be processed by MockPreemptionThread
    Thread.yield();{code} be put into a common method to be called from all the test methods?
 And maybe call that from {{testPreemptionDisabled()}} as well so that you give it a fair
chance to prove that it really is disabled?

> Verify applications are identified starved
> ------------------------------------------
>
>                 Key: YARN-5783
>                 URL: https://issues.apache.org/jira/browse/YARN-5783
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: fairscheduler
>    Affects Versions: 2.8.0
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>              Labels: oct16-medium
>         Attachments: yarn-5783.YARN-4752.1.patch, yarn-5783.YARN-4752.2.patch, yarn-5783.YARN-4752.3.patch,
yarn-5783.YARN-4752.4.patch, yarn-5783.YARN-4752.5.patch
>
>
> JIRA to track unit tests to verify the identification of starved applications. An application
should be marked starved only when:
> # Cluster allocation is over the configured threshold for preemption.
> # Preemption is enabled for a queue and any of the following:
> ## The queue is under its minshare for longer than minsharePreemptionTimeout
> ## One of the queue’s applications is under its fairshare for longer than fairsharePreemptionTimeout.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message