hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Varun Saxena (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5739) Provide timeline reader API to list available timeline entity types for one application
Date Tue, 22 Nov 2016 19:44:58 GMT

    [ https://issues.apache.org/jira/browse/YARN-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15687692#comment-15687692
] 

Varun Saxena commented on YARN-5739:
------------------------------------

Thanks [~gtCarrera9] for the patch. Few comments.

# In TimelineReaderWebServices, do we need this code block ? Looking at code, list of entity
types can be empty, but it cannot be null.
{code}
    if (results == null) {
      LOG.info("Processed URL " + url + " but app not found" + " (Took " +
          (endTime - startTime) + " ms.)");
      throw new NotFoundException("App " + appId + " not found");
    }
{code}
# In EntityTypeReader#getNextRowKey, below javadoc should say application id instead of application
information. Also saying "Should not be changed during iteration" doesn't seem at right place
in method javadoc. Probably add a comment in caller ?
{code}
   * @param currRowKeyPrefix The current prefix that contains user, cluster,
   *                         flow, run, and application information. Should not
   *                         be changed during the iteration.
{code}
# In TimelineStorageUtils#calculateTheClosestNextRowKeyForPrefix javadoc, there is a typo.
{{represneted}} should be {{represented}}
# For the newly added javadoc in TimelineReaderManager, should we say {{Gets a list of available
timeline entity types for an application}} ?

Moreover, REST endpoint suggestion was both entity-types and entitytypes. I am fine with both
as we do use hyphen in other REST endpoints in YARN. Let us go with majority opinion. [~sjlee0],
your view on this ?
We are first getting entities and then extracting types from it. But I guess there will be
a lot of code duplication if we do not do this. Right ?

> Provide timeline reader API to list available timeline entity types for one application
> ---------------------------------------------------------------------------------------
>
>                 Key: YARN-5739
>                 URL: https://issues.apache.org/jira/browse/YARN-5739
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelinereader
>            Reporter: Li Lu
>            Assignee: Li Lu
>         Attachments: YARN-5739-YARN-5355.001.patch, YARN-5739-YARN-5355.002.patch, YARN-5739-YARN-5355.003.patch
>
>
> Right now we only show a part of available timeline entity data in the new YARN UI. However,
some data (especially library specific data) are not possible to be queried out by the web
UI. It will be appealing for the UI to provide an "entity browser" for each YARN application.
Actually, simply dumping out available timeline entities (with proper pagination, of course)
would be pretty helpful for UI users. 
> On timeline side, we're not far away from this goal. Right now I believe the only thing
missing is to list all available entity types within one application. The challenge here is
that we're not storing this data for each application, but given this kind of call is relatively
rare (compare to writes and updates) we can perform some scanning during the read time. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message