hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jian He (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (YARN-5694) ZKRMStateStore should always start its verification thread to prevent accidental state store corruption
Date Mon, 21 Nov 2016 21:45:58 GMT

    [ https://issues.apache.org/jira/browse/YARN-5694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15684826#comment-15684826
] 

Jian He edited comment on YARN-5694 at 11/21/16 9:45 PM:
---------------------------------------------------------

bq. (Currently, it's only started with manual failover, which doesn't make any sense.)
IIRC, it's started only with manual failover because, in case of curator based leader elector,
the curator library will trigger notification  already if RM is not active. No need for an
additional polling thread...  This maybe the case for Hadoop's ActiveStandbyElector too..
If you think it's better to keep this for Hadoop's ActiveStandbyElector , maybe we can do
something like:  {{if (HA.isEnabled()  &&  !curatorEnabled)}}




was (Author: jianhe):
bq. (Currently, it's only started with manual failover, which doesn't make any sense.)
IIRC, it's started only with manual failover because, in case of curator based leader elector,
the curator library will trigger notification  already if RM is not active. No need for an
additional polling thread...  This maybe the case for Hadoop's ActiveStandbyElector too..
If you think it's better to keep this for Hadoop's ActiveStandbyElector , maybe we can do
something like:  {{ if (HA.isEnabled()  &&  !curatorEnabled) }}



> ZKRMStateStore should always start its verification thread to prevent accidental state
store corruption
> -------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-5694
>                 URL: https://issues.apache.org/jira/browse/YARN-5694
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Daniel Templeton
>            Assignee: Daniel Templeton
>            Priority: Critical
>              Labels: oct16-medium
>         Attachments: YARN-5694.001.patch, YARN-5694.002.patch, YARN-5694.003.patch, YARN-5694.004.patch,
YARN-5694.004.patch, YARN-5694.005.patch, YARN-5694.006.patch, YARN-5694.007.patch, YARN-5694.008.patch,
YARN-5694.branch-2.7.001.patch, YARN-5694.branch-2.7.002.patch
>
>
> There are two cases.  In branch-2.7, the {{ZKRMStateStore.VerifyActiveStatusThread}}
is always started, even when using embedded or Curator failover.  In branch-2.8, the {{ZKRMStateStore.VerifyActiveStatusThread}}
is only started when HA is disabled, which makes no sense.  Based on the JIRA that introduced
that change (YARN-4559), I believe the intent was to start it only when embedded failover
is disabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message