hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Templeton (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (YARN-5694) ZKRMStateStore should always start its verification thread to prevent accidental state store corruption
Date Mon, 21 Nov 2016 18:09:58 GMT

     [ https://issues.apache.org/jira/browse/YARN-5694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Daniel Templeton updated YARN-5694:
-----------------------------------
    Attachment: YARN-5694.008.patch

This patch turns the active status thread back on whenever HA is on.  (Currently, it's only
started with manual failover, which doesn't make any sense.)  This patch also removes the
synchronization from {{closeInternal()}} because it causes the active status thread to hang
instead of exiting.

> ZKRMStateStore should always start its verification thread to prevent accidental state
store corruption
> -------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-5694
>                 URL: https://issues.apache.org/jira/browse/YARN-5694
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Daniel Templeton
>            Assignee: Daniel Templeton
>            Priority: Critical
>              Labels: oct16-medium
>         Attachments: YARN-5694.001.patch, YARN-5694.002.patch, YARN-5694.003.patch, YARN-5694.004.patch,
YARN-5694.004.patch, YARN-5694.005.patch, YARN-5694.006.patch, YARN-5694.007.patch, YARN-5694.008.patch,
YARN-5694.branch-2.7.001.patch, YARN-5694.branch-2.7.002.patch
>
>
> There are two cases.  In branch-2.7, the {{ZKRMStateStore.VerifyActiveStatusThread}}
is always started, even when using embedded or Curator failover.  In branch-2.8, the {{ZKRMStateStore.VerifyActiveStatusThread}}
is only started when HA is disabled, which makes no sense.  Based on the JIRA that introduced
that change (YARN-4559), I believe the intent was to start it only when embedded failover
is disabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message