hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Miklos Szegedi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-5600) Add a parameter to ContainerLaunchContext to emulate yarn.nodemanager.delete.debug-delay-sec on a per-application basis
Date Mon, 14 Nov 2016 22:47:59 GMT

    [ https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15665283#comment-15665283
] 

Miklos Szegedi commented on YARN-5600:
--------------------------------------

Thank you, [~vvasudev] for the review!
I will send a revised patch shortly.
1) 2) You are right, I moved the constant definition out from YarnConfiguration.
3) I removed -1 as the default value. However, the more changes and administrator needs to
do to enable the feature, the less likely it will be used. Because of this I suggest using
10 minutes as a default.
  This allows the user to modify an application launch and copy the results, when needed without
a reboot. Is 10 minutes acceptable in a production cluster?
  The administrator can change this to 0 with a reboot. What do you think?
4) I agree. Removing the forever option makes the code cleaner and easier to maintain. Note:
this change will break backward compatibility, although -1 was not documented before.
5) I changed the logging to info as requested.
6) This was probably my toolset. I moved it back to the original location.
7) Since I changed significant portions, I decided to fix checkstyle violations in the file.
checkstyle was the reason to rename these variables.


> Add a parameter to ContainerLaunchContext to emulate yarn.nodemanager.delete.debug-delay-sec
on a per-application basis
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-5600
>                 URL: https://issues.apache.org/jira/browse/YARN-5600
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: nodemanager
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Daniel Templeton
>            Assignee: Miklos Szegedi
>              Labels: oct16-medium
>         Attachments: YARN-5600.000.patch, YARN-5600.001.patch, YARN-5600.002.patch, YARN-5600.003.patch,
YARN-5600.004.patch, YARN-5600.005.patch, YARN-5600.006.patch, YARN-5600.007.patch, YARN-5600.008.patch,
YARN-5600.009.patch
>
>
> To make debugging application launch failures simpler, I'd like to add a parameter to
the CLC to allow an application owner to request delayed deletion of the application's launch
artifacts.
> This JIRA solves largely the same problem as YARN-5599, but for cases where ATS is not
in use, e.g. branch-2.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message